python3-pefile: vendor in the recipe #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably vendor the latest version (updated 3 days ago) instead: https://git.openembedded.org/meta-openembedded/commit/?id=0e6ba2d70844843d057f41f884df676b9314c9d6 Probably also good to point to the git hash used as reference in the commit message. Typo nit: s/Suggestd-by/Suggested-by/ |
lumag
force-pushed
the
vendor-pefile
branch
from
a1ae863
to
0a93226
Compare
Vendor the recipe from meta-oe, commit 0e6ba2d70844 ("python3-pefile:
upgrade 2023.2.7 -> 2024.8.26") This allows us to build the
esp-qcom-image without adding dependency on the meta-oe. Python-pefile
should be moved from meta-oe to OE-Core, then this recipe can be
dropped.
Suggested-by: Ricardo Salveti <ricardo@foundries.io>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
lumag
force-pushed
the
vendor-pefile
branch
from
0a93226
to
dbdbdb7
Compare
|
Thanks for the suggestions. I've updated the recipe and I'll merge it once build succeeds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor the recipe from meta-oe. This allows us to build the esp-qcom-image without adding dependency on the meta-oe. Python-pefile should be moved from meta-oe to OE-Core, then this recipe can be dropped.
Suggestd-by: Ricardo Salveti ricardo@foundries.io