-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta-qcom: build fixes #645
Conversation
conf/machine/qcom-armv8a.conf
Outdated
@@ -29,6 +29,8 @@ KERNEL_DEVICETREE:append:pn-linux-yocto = " \ | |||
qcom/qcs6490-rb3gen2.dtb \ | |||
" | |||
|
|||
INITRAMFS_IMAGE ?= "initramfs-qcom-image" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being handled by #637
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi.
Thanks for let me know. I completely miss that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. It's better to get another report rather than have a bug. Thank you for your efforts!
@@ -10,5 +10,4 @@ RRECOMMENDS:${PN} += " \ | |||
linux-firmware-lt9611uxc \ | |||
linux-firmware-qcom-sm8250-audio \ | |||
linux-firmware-qcom-sm8250-compute \ | |||
linux-firmware-qcom-vpu \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, OE-Core provides this package as a part of linux-firmware_20240909.bb
. What is your build environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using:
https://github.com/openembedded/meta-openembedded/tree/master
https://github.com/openembedded/meta-openembedded/tree/master/meta-oe
Like suggested into the doc. But tbh I can't see linux-firmware_20240909.bb or I'm wrong?
Thanks in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fault, thanks.
I miss to update those repos :'(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries.
@@ -8,7 +8,7 @@ LICENSE_FILE = "LICENSE.qcom" | |||
LICENSE_FILE_PDF = "NO.LOGIN.BINARY.LICENSE.QTI.pdf" | |||
|
|||
LIC_FILES_CHKSUM = "file://${LICENSE_FILE};md5=164e3362a538eb11d3ac51e8e134294b \ | |||
file://${LICENSE_FILE_PDF};md5=e1d82f4252cf04ba59b8b9d0011e0180 \ | |||
file://${LICENSE_FILE_PDF};md5=e5b448b978ed6d4f8d29c94a7a213b81 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. If you check, ${LICENSE_FILE_PDF}
incorrect, it points to UI interface rather than the PDF file. I will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the variable, of course, but the SRC_URI part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #646
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And thank you for the report. I didn't verify the URI, which resulted in this error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Rootfs for qcs6490-rb3gen2 machine is placed under system partition. Let's set this info into QCOM_BOOTIMG_ROOTFS var that set the rootfs position for kernel cmdline. Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
f8aa4d4
to
4bace93
Compare
Hi,
Testing rb3gen2 build some build errors have been found.
Let's fix that by this patchset.
Regards,
Tommaso