Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CodeArtifact): add option to provide aws credentials directly #4

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Khartris
Copy link
Member

@Khartris Khartris commented Apr 9, 2024

TLDR: This PR adds the option to declare AWS credentials directly instead of pulling them from a profile.

Background: We have a project where we need two sets of AWS credentials for our e2e tests (one is for us and one is for our customer). Locally we have two profiles for them, but in our gitlab CI we inject these via environment variables. When I tried to add this plugin to our project I encountered the problem that it only accepts profiles for selecting the correct credentials. This works fine locally but in our CI the plugin simply takes the default credentials from the environment variables which are the wrong ones. As our CI has no profiles we cannot select the correct credentials with this plugin. My solution is to add the option to directly declare the accessKeyId and secretAccessKey in the configuration (e.g. via environment variables).

@Khartris Khartris requested a review from Ingwersaft April 9, 2024 12:41
@Ingwersaft Ingwersaft merged commit 102a2b3 into main Apr 9, 2024
1 check passed
@Ingwersaft Ingwersaft deleted the feat/allow_manual_addition_of_aws_credentials branch April 9, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants