Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTS-417 Update example scripts to account for new API changes #3

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

obukatar
Copy link

https://leia3d.atlassian.net/browse/MTS-417

  • Add the example scripts using the Leia Storage API.
  • Updated the README.

Also FYI:
https://github.com/LeiaInc/MediaCloudRESTAPI/pull/91

Copy link
Collaborator

@vit-lebediev vit-lebediev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! But let's wait until we merge & release changes to storage API.

@vit-lebediev vit-lebediev marked this pull request as draft March 1, 2024 03:58
@vit-lebediev
Copy link
Collaborator

I'll move it to draft to indicate that it should not be reviewed just yet

* omit the generation of PUT pre-signed URLs, as it is now optional.
Copy link
Collaborator

@vit-lebediev vit-lebediev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG with small suggestion.

// We start with preparing a correlationId. This might be an internal
// ID which you use in your system for this image/entity represented
// by the image/etc, or, as we do now, we can just generate new UUIDv4.
let correlationId = uuidv4();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should show that correlationId is optional, and can be omitted. We will generate correlationId on the go for requests which don't have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants