-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTS-417 Update example scripts to account for new API changes #3
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! But let's wait until we merge & release changes to storage API.
I'll move it to draft to indicate that it should not be reviewed just yet |
* omit the generation of PUT pre-signed URLs, as it is now optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG with small suggestion.
// We start with preparing a correlationId. This might be an internal | ||
// ID which you use in your system for this image/entity represented | ||
// by the image/etc, or, as we do now, we can just generate new UUIDv4. | ||
let correlationId = uuidv4(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should show that correlationId
is optional, and can be omitted. We will generate correlationId
on the go for requests which don't have it.
https://leia3d.atlassian.net/browse/MTS-417
Also FYI:
https://github.com/LeiaInc/MediaCloudRESTAPI/pull/91