Update Dynamic FPS supported versions and metadata #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's dependent on the order that is used to list versions in the JS file. |
|
Hi, thank you for merging this! Sadly I only noticed on the production site now that the GitHub URL is made from the author name(s), so I unfortunately broke the link. Since I don't think it's worth opening a PR to fix that could you do so at some point? Thank you and sorry for missing that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed that the supported version range for Dynamic FPS on Fabric is incomplete as some versions for the earlier 1.14.x and 1.16.x releases never made it to Modrinth (and I am not looking to provide backports for them), so I figured it would be reasonable to add them manually as they are available on GitHub and CurseForge. If this is not the case feel free to close this PR.
While I was at it I also fixed supported NeoForge versions, updated the description since it was changed a little while ago, and added myself to the author list as I maintain the mod.
... I'm not sure why Fabric and Quilt switched places but I don't think that really matters.