Update lib.html and fix null tooltip handling.

LambdAurora · May 24, 2024 · abc34cf · abc34cf
1 parent 3aa9daf
commit abc34cf
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -74,3 +74,8 @@
 - Fixed inline HTML block element name from `InlineHTML` to `InlineHtml`.
 - Fixed comments being badly inserted inside documents.
 - Updated lib.html.
+
+### 2.1.1
+
+- Fixed null tooltip handling.
+- Updated lib.html.
diff --git a/deno.lock b/deno.lock
diff --git a/import_map.json b/import_map.json
@@ -1,6 +1,6 @@
 {
 	"imports": {
-		"@lambdaurora/libhtml": "jsr:@lambdaurora/libhtml@^1.1.3",
+		"@lambdaurora/libhtml": "jsr:@lambdaurora/libhtml@^1.2.1",
 		"@std/assert": "jsr:@std/assert@^0.225.3",
 		"@std/fs": "jsr:@std/fs@^0.229.1",
 		"@oak/oak": "jsr:@oak/oak@^16.0.0",

diff --git a/lib/tree/base.ts b/lib/tree/base.ts
@@ -196,7 +196,11 @@ export class Reference {
 	 * @return `true` if this reference has a tooltip, or `false` otherwise.
 	 */
 	public has_tooltip(): boolean {
-		return this.tooltip !== undefined && this.tooltip !== "";
+		if (this.tooltip) {
+			return true;
+		} else {
+			return false;
+		}
 	}
 
 	public toString(): string {

diff --git a/test/footnote.test.ts b/test/footnote.test.ts
@@ -34,12 +34,18 @@ Deno.test("Renderer > footnotes", () => {
 	</p>
 	<hr />
 	<ol class="footnotes">
-		<li id="fn:1">Simple text
-			<a class="footnote_src_link" href="#fn:1:src">↩</a></li>
-		<li id="fn:fancy-name">Fancy name footnote.
-			<a class="footnote_src_link" href="#fn:fancy-name:src">↩</a></li>
-		<li id="fn:3">Moar text
-			<a class="footnote_src_link" href="#fn:3:src">↩</a></li>
+		<li id="fn:1">
+			Simple text
+			<a class="footnote_src_link" href="#fn:1:src">↩</a>
+		</li>
+		<li id="fn:fancy-name">
+			Fancy name footnote.
+			<a class="footnote_src_link" href="#fn:fancy-name:src">↩</a>
+		</li>
+		<li id="fn:3">
+			Moar text
+			<a class="footnote_src_link" href="#fn:3:src">↩</a>
+		</li>
 	</ol>
 </div>`);
 });