Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix CD pipeline #283

Merged
merged 13 commits into from
Jul 9, 2024
Merged

Hotfix CD pipeline #283

merged 13 commits into from
Jul 9, 2024

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Jul 8, 2024

Summary

  • This PR is a release hotfix and will be tagged as v2024.06.1 after merge...
  • It does the following:
    • Moves the steps for creating our dev-pkg / tar file out of gitlab and into a standalone script.
    • Fixes the broken Continuous Deployment pipeline that was silently broken during the latest spack update.
      • The -d option for spack buildcache is no longer supported. We need to first create a mirror and then point the cache to that mirror.
    • Possibly fixes a bug seen when building on air gapped builds where concretization is different from the buildcache and the final install.
      • Flags for concretization and installation need to be the same in this case we are setting --fresh and --deprecated.
    • Sets libjpeg as the provider package for the virtual spack package jpeg for toss4 builds.
      • During development it was noticed that sometimes py-pillow would try to build with providers of jpeg that were not the basic libjpeg package during the installation locking this seems to resolve the issue.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#90)
  • LLNLSpheral PR has passed all tests.

@mdavis36 mdavis36 marked this pull request as ready for review July 9, 2024 04:13
@mdavis36 mdavis36 requested review from jmikeowen and ldowen July 9, 2024 04:13
@jmikeowen
Copy link
Collaborator

If we're doing a patch release could we go ahead and bring in that fix for our use of Axom in the polyhedron containment query? Even though the error is probably harmless, might as well fix this known issue if we're doing a patch release.

@mdavis36 mdavis36 merged commit 93ebb5d into main Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants