Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spack to 0.22 #272

Merged
merged 47 commits into from
Jun 18, 2024
Merged

Update Spack to 0.22 #272

merged 47 commits into from
Jun 18, 2024

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented May 3, 2024

Summary

  • This PR updates Spack and aspects of the TPLs
  • It does the following:
    • The Spack hash used by uberenv is updated
    • The TPL Spack packages are updated or removed if possible
    • TPL manager logic is modified so only a single install call occurs
    • Spack configurations are updated
    • Package providers are set to avoid arbitrary concretization issues for downstream libraries

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#82)
  • LLNLSpheral PR has passed all tests.

@ldowen ldowen requested review from jmikeowen and mdavis36 May 3, 2024 21:00
cmake/tpl/zlib.cmake Show resolved Hide resolved
scripts/devtools/tpl-manager.py Outdated Show resolved Hide resolved
scripts/devtools/tpl-manager.py Show resolved Hide resolved
scripts/devtools/tpl-manager.py Show resolved Hide resolved
scripts/devtools/tpl-manager.py Show resolved Hide resolved
scripts/spack/configs/blueos_3_ppc64le_ib/packages.yaml Outdated Show resolved Hide resolved
scripts/spack/configs/config.yaml Outdated Show resolved Hide resolved
scripts/spack/configs/toss_4_x86_64_ib/packages.yaml Outdated Show resolved Hide resolved
scripts/spack/packages/opensubdiv/package.py Show resolved Hide resolved
scripts/spack/packages/spheral/package.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mdavis36 mdavis36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on getting through this slog, hopefully we can start to update more regularly and avoid such a heavy lift in the future. Just a couple of questions and one change request in terms of our upstream directory name. I hope it isn't too much of a pain to move ...

.gitlab/os.yml Outdated Show resolved Hide resolved
scripts/spack/configs/ubuntu20.04/packages.yaml Outdated Show resolved Hide resolved
scripts/spack/configs/ubuntu20.04/packages.yaml Outdated Show resolved Hide resolved
@mdavis36 mdavis36 added this to the 2024.06.0 Release milestone Jun 9, 2024
@mdavis36
Copy link
Collaborator

@ldowen LGTM

@ldowen ldowen merged commit 28fb2fc into develop Jun 18, 2024
2 checks passed
@ldowen ldowen deleted the update/update_TPLs branch June 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants