Mark GroupMetadataV3 and ArrayMetadataV3 as non-exhaustive
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 162 162
Lines 22463 22463
=======================================
Hits 18681 18681
Misses 3782 3782 ☔ View full report in Codecov by Sentry. |
LDeakin
force-pushed
the
v3_metadata_non_exhaustive
branch
from
2dc6150
to
73eda4e
Compare
LDeakin
force-pushed
the
v3_metadata_non_exhaustive
branch
from
73eda4e
to
7d5bc4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays andGroups can now only be constructed with builders.This will preserve backwards compat when new fields are added in the future (e.g. consolidated metadata).