Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [partial_]decode_into API #75

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add [partial_]decode_into API #75

merged 1 commit into from
Sep 19, 2024

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Sep 19, 2024

Resolves a performance regression introduced in 0.16 when decoding sharded arrays with Array::[async_]retrieve_array_subset_opt.

Improves performance when decoding sharded arrays with `Array::[async_]retrieve_array_subset_opt`.
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 28 lines in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (65542cc) to head (9d21650).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zarrs/src/array/array_sync_readable.rs 90.00% 9 Missing ⚠️
zarrs/src/array/array_async_readable.rs 91.75% 8 Missing ⚠️
...ay/codec/array_to_bytes/sharding/sharding_codec.rs 93.45% 7 Missing ⚠️
zarrs/src/array/codec.rs 95.45% 3 Missing ⚠️
...arrs/src/array/codec/array_to_bytes/codec_chain.rs 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   82.72%   82.96%   +0.23%     
==========================================
  Files         162      162              
  Lines       22228    22626     +398     
==========================================
+ Hits        18389    18771     +382     
- Misses       3839     3855      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin marked this pull request as ready for review September 19, 2024 09:04
@LDeakin LDeakin merged commit 26b90dd into main Sep 19, 2024
22 checks passed
@LDeakin LDeakin deleted the decode_into branch September 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant