Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codec partial encoders #45

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Codec partial encoders #45

wants to merge 1 commit into from

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Jul 30, 2024

This is mainly to support incremental writing of large shards similar to the encoding procedure outlined in the sharding specification.

Addresses LDeakin/zarrs_tools#9.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 86.03043% with 101 lines in your changes missing coverage. Please review.

Project coverage is 83.29%. Comparing base (10d3b80) to head (67052f3).

Files with missing lines Patch % Lines
...array/codec/bytes_partial_encoder_default_async.rs 77.94% 15 Missing ⚠️
.../array/codec/bytes_partial_encoder_default_sync.rs 77.61% 15 Missing ⚠️
...s/src/array/codec/storage_partial_encoder_async.rs 74.19% 8 Missing ⚠️
...rs/src/array/codec/storage_partial_encoder_sync.rs 77.77% 8 Missing ⚠️
zarrs/src/array/array_async_readable_writable.rs 83.33% 7 Missing ⚠️
zarrs/src/array/array_sync_readable_writable.rs 85.36% 6 Missing ⚠️
...array/codec/array_partial_encoder_default_async.rs 92.98% 4 Missing ⚠️
...ec/array_to_array_partial_encoder_default_async.rs 92.45% 4 Missing ⚠️
...dec/array_to_array_partial_encoder_default_sync.rs 92.98% 4 Missing ⚠️
.../array/codec/array_partial_encoder_default_sync.rs 95.08% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   83.16%   83.29%   +0.12%     
==========================================
  Files         162      170       +8     
  Lines       22463    23161     +698     
==========================================
+ Hits        18681    19291     +610     
- Misses       3782     3870      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin force-pushed the partial_encoders branch 5 times, most recently from a69de2e to 53e6cd3 Compare August 15, 2024 00:00
@LDeakin LDeakin force-pushed the partial_encoders branch 4 times, most recently from 9b2bedc to c546dd8 Compare September 19, 2024 23:59
@LDeakin LDeakin added enhancement New feature or request breaking-changes The PR has API changes labels Oct 3, 2024
@LDeakin LDeakin force-pushed the partial_encoders branch 4 times, most recently from ed0be16 to 204c2c8 Compare October 4, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes The PR has API changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant