Improving perf when using InMemory storage #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
reviewed
Jun 16, 2023
didierofrivia
force-pushed
the
faster-baby-ii
branch
from
44310d0
to
ae0084c
Compare
didierofrivia
force-pushed
the
faster-baby-ii
branch
from
6ec5b78
to
3c1ed26
Compare
didierofrivia
changed the title
didierofrivia
changed the title
alexsnaps
requested changes
Jul 8, 2023
didierofrivia
force-pushed
the
faster-baby-ii
branch
from
3c1ed26
to
2fafbed
Compare
* Storing now in ExpiringValue type within the main structure of nested HashMaps
* Making first loop faster not modifying counters, read only * Second loop updates de counters [refactor] Refactoring inMemory, check when load_counters in Vacant branch [refactor] Refactoring inMemory -> fixing performance in check _and_update [refactor] Refactoring InMemory -> first loop faster, not modifying storage
didierofrivia
force-pushed
the
faster-baby-ii
branch
from
2fafbed
to
326986b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also part of #183
Criterion performance results for In Memory storage, check_rate_limited_and_update function
10 namespaces with 10 limits each with 10 conditions and 10 variables
10 namespaces with 50 limits each with 10 conditions and 10 variables