chore: Simplify DNSPolicy API #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbrookes
reviewed
Sep 16, 2024
mikenairn
force-pushed
the
simplify_dnspolicy_api
branch
3 times, most recently
from
76ea510
to
994148b
Compare
mikenairn
force-pushed
the
simplify_dnspolicy_api
branch
from
994148b
to
0933af9
Compare
maleck13
reviewed
Sep 17, 2024
maleck13
reviewed
Sep 17, 2024
|
The changes look reasonable to me just not sure why we removed the test file and also perhaps we should go with optional on weight |
mikenairn
force-pushed
the
simplify_dnspolicy_api
branch
2 times, most recently
from
0f64419
to
35b569a
Compare
* Remove RoutingStrategy field. LoadBalanced vs Simple can be inferred
from the value of the LoadBalancingSpec on the policy.
* Simplify LoadBalancingSpec:
- No longer uses label selectors to get values for geo or weight from
a metav1.Object, but the values themselves should be set directly in
the policy.
- LoadBalancingSpec.DefaultGeo specifies if the current geo is the
default one or not and signals to the endpoint generation whether to
create the wildcard catch all endpoint.
Signed-off-by: Michael Nairn <mnairn@redhat.com>
mikenairn
force-pushed
the
simplify_dnspolicy_api
branch
from
35b569a
to
b78618a
Compare
mikenairn
commented
Sep 17, 2024
mikenairn
commented
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #855