codecov: do not fail ci on error

[KevFan]

• Prevent codecov from failing ci on error due to flakiness with codecov upload

[codecov]

Codecov Report

Merging #228 (4b929af) into main (473cb4a) will increase coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   61.79%   62.53%   +0.73%     
==========================================
  Files          33       33              
  Lines        3112     3112              
==========================================
+ Hits         1923     1946      +23     
+ Misses        998      980      -18     
+ Partials      191      186       -5     

Flag	Coverage Δ
integration	68.20% <ø> (+1.43%)	⬆️
unit	56.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	26.86% <ø> (ø)
pkg/common (u)	77.27% <ø> (ø)
pkg/istio (u)	29.69% <ø> (ø)
pkg/log (u)	31.81% <ø> (ø)
pkg/reconcilers (u)	40.16% <ø> (ø)
pkg/rlptools (u)	54.47% <ø> (ø)
controllers (i)	68.20% <ø> (+1.43%)	⬆️

see 8 files with indirect coverage changes

[adam-cattermole]

Looks good to me

[art-tapin]

Hey @KevFan!
The CodeCov uploads the results two times: for unit tests and for integration tests separately. Please, check out the line 90 in test.yaml to change the true condition to false for integration tests too:

      - name: Upload integration-test coverage reports to CodeCov # more at https://github.com/codecov/codecov-action
       uses: codecov/codecov-action@v3
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
         flags: integration
         fail_ci_if_error: true
         verbose: true

[KevFan]

Thanks @art-tapin ! Good catch, I've pushed that change just now 👍