make security requirements optional #56
Conversation
eguzki
force-pushed
the
refactor-api-selectors
branch
from
d56fcca
to
d0a6d59
Compare
eguzki
force-pushed
the
make-security-optional
branch
from
0cfb94b
to
f7f1904
Compare
eguzki
force-pushed
the
refactor-api-selectors
branch
from
d0a6d59
to
a2f4946
Compare
eguzki
force-pushed
the
make-security-optional
branch
from
f7f1904
to
dce049f
Compare
eguzki
force-pushed
the
refactor-api-selectors
branch
from
a2f4946
to
51a8900
Compare
eguzki
force-pushed
the
make-security-optional
branch
2 times, most recently
from
6ac3f69
to
735805a
Compare
| Name: common.KuadrantAuthorizationProvider, | ||
| }, | ||
| }, | ||
| Action: v1beta12.AuthorizationPolicy_CUSTOM, |
There was a problem hiding this comment.
Out of scope here, but there's a request for discussing the conventions across components at Kuadrant/authorino#164
| Hosts []string `json:"hosts"` | ||
|
|
||
| // Configure authentication mechanisms | ||
| // +optional |
There was a problem hiding this comment.
Is this needed for controller-gen to make it optional? I usually rely only on omitempty and it does the trick, but I'd love to learn about any other extra advantage.
There was a problem hiding this comment.
I have experienced that too. That's confusing as the kubebulder doc says it should be the '+optional marker.
To make it explicit and easy to read, I always add it for optional fields
There was a problem hiding this comment.
Perhaps +kubebuilder:validation:Optional then, so there's no doubt it's for kubebuilder?
eguzki
force-pushed
the
refactor-api-selectors
branch
2 times, most recently
from
23026d6
to
dedf108
Compare
eguzki
force-pushed
the
make-security-optional
branch
from
735805a
to
ad3c5da
Compare
|
Added fix for the apiproduct status subresource computing logic when resources are optional. |
eguzki
force-pushed
the
refactor-api-selectors
branch
from
dedf108
to
7bc3213
Compare
reconcile adding and removing sec from apiproduct
eguzki
force-pushed
the
make-security-optional
branch
from
88623eb
to
e54d4eb
Compare
Support for APIProduct obejcts without security (AuthN) configuration
Reconcile adding and removing security from apiproduct
This PR is based on #55, it is ready for review, but should be merged after it