Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Quickstart doc #58

Merged
merged 1 commit into from
Feb 1, 2024
Merged

API Quickstart doc #58

merged 1 commit into from
Feb 1, 2024

Conversation

jasonmadigan
Copy link
Member

API quickstart doc.

WIP at the moment.

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan
Copy link
Member Author

/hold

@david-martin
Copy link
Contributor

@jasonmadigan
Trying this out locally, it doesn't like the private repo:

mkdocs_multirepo_plugin.util.BashException:
Cloning into 'api-quickstart'...
remote: Support for password authentication was removed on August 13, 2021.
remote: Please see https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication.
fatal: Authentication failed for 'https://github.com/kuadrant/api-quickstart/'

Should we move the repo to public, or switch to an ssh url so key auth is used?

@jasonmadigan
Copy link
Member Author

@david-martin this should work locally now.

@david-martin
Copy link
Contributor

The wiring up works locally.
The document looks to render correctly, though I haven't gone through it fully.
Once this is merged, is there an extra step to deploy, or is the README from main of api-quickstart deployed there and then?
Should we hold off merge until the current round of testing and updates finish?

@jasonmadigan
Copy link
Member Author

jasonmadigan commented Jan 31, 2024

@david-martin yes I think this should remain on hold for a while more.

@jasonmadigan
Copy link
Member Author

@R-Lawton @david-martin merged

@jasonmadigan jasonmadigan merged commit 23f184b into main Feb 1, 2024
2 of 3 checks passed
@jasonmadigan jasonmadigan deleted the 36-api-quickstart-in-docs branch February 1, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

API Quickstart in docs
2 participants