Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add dns-provider guide #112

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented May 15, 2024

@openshift-ci openshift-ci bot requested review from R-Lawton and Ygnas May 15, 2024 08:14
Copy link

netlify bot commented May 15, 2024

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit 002d452
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/6661c981037cf5000819a152
😎 Deploy Preview https://deploy-preview-112--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@david-martin
Copy link
Contributor

👀

@david-martin
Copy link
Contributor

Were there any recent changes to the doc page in particular?

Noticed a url that doesn't render as a link. I think it's because of a missing newline before it?

image

@jasonmadigan
Copy link
Member Author

No I believe it was copied as-is during the great migration. Good spot on the broken/unlinked link

jasonmadigan added a commit to Kuadrant/dns-operator that referenced this pull request Jun 4, 2024
Noticed a URL formatting issue when looking at:

Kuadrant/docs.kuadrant.io#112
@jasonmadigan
Copy link
Member Author

@david-martin Mike has landed a change to fix the formatting. I've not found a way to get the netflify bot to rebuild yet..

@jasonmadigan
Copy link
Member Author

Hmm, odd. Usually single-line links are transformed into hyperlinks, but not so:

https://deploy-preview-112--graceful-kangaroo-3c9c10.netlify.app/dns-operator/docs/provider/

@david-martin
Copy link
Contributor

I think they'll have to be markdown formatted links.
I tested locally with this and it renders ok

[https://cloud.google.com/dns/docs/access-control#dns.admin](https://cloud.google.com/dns/docs/access-control#dns.admin)

@jasonmadigan
Copy link
Member Author

Have patched in Kuadrant/dns-operator#154

@jasonmadigan
Copy link
Member Author

@david-martin
Copy link
Contributor

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 24b2d62 into main Jun 6, 2024
8 checks passed
@jasonmadigan jasonmadigan deleted the re-add-dnsprovider-guide branch September 20, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants