gpu: More pre-work to combine Printf and GPUAV #8611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 266267. |
spencer-lunarg
commented
Sep 27, 2024
| @@ -526,3 +526,165 @@ void CommandBuffer::PostProcess(VkQueue queue, const Location &loc) { | |||
| } | |||
|
|
|||
| } // namespace gpuav | |||
|
|
|||
|
|
|||
| namespace gpu_tracker { | |||
There was a problem hiding this comment.
the final move will be to remove this namespace but keep the logic in this file (where it belongs)
|
CI Vulkan-ValidationLayers build # 17621 running. |
arno-lunarg
approved these changes
Sep 27, 2024
| @@ -1362,7 +1369,7 @@ bool GpuShaderInstrumentor::InstrumentShader(const vvl::span<const uint32_t> &in | |||
| gpu::spirv::Module module(input_spirv, debug_report, module_settings); | |||
|
|
|||
| // For now, we don't yet support (or have tested) combining GPU-AV and DebugPrintf, so have 2 paths here | |||
| const bool is_debug_printf = container_type == LayerObjectTypeDebugPrintf; | |||
There was a problem hiding this comment.
Could just use debug_printf_enabled directly instead of is_debug_printf
There was a problem hiding this comment.
ya, we are going to need to change this from is_debug_printf to is_only_debug_printf anyways.. basically my main goal was to just remove anyone trying to read from LayerObjectTypeDebugPrintf lol
|
CI Vulkan-ValidationLayers build # 17621 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes work from and brings out things that can be done now that will make the "final merge" PR more readable
cedb681