Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Remove Deprecated m_commandBuffer #8591

Merged

Conversation

spencer-lunarg
Copy link
Contributor

    vkt::CommandBuffer *m_commandBuffer;  // DEPRECATED: use m_command_buffer
    vkt::CommandBuffer m_command_buffer;

(needed a mental break from real programming) and took all test files that likely are not going to be touched in the near future (to prevent rebasing) and started this transition to finally get rid of m_commandBuffer so we don't have 2 way to call command buffer

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner September 25, 2024 04:31
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 263662.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17581 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17581 passed.

@artem-lunarg artem-lunarg merged commit b1aa28e into KhronosGroup:main Sep 25, 2024
21 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-test-wow2 branch September 25, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants