Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Simplify threading configuration #8589

Merged
merged 1 commit into from
Sep 25, 2024
Merged

tests: Simplify threading configuration #8589

merged 1 commit into from
Sep 25, 2024

Conversation

artem-lunarg
Copy link
Contributor

When this test was introduced running time could vary 10x depending on the device. Reduce the number of threads to reduce threading contention (but still keep high enough) with a hope to make running time a bit less unpredictable.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 263518.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17578 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17578 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 263540.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17579 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17579 passed.

@artem-lunarg artem-lunarg marked this pull request as ready for review September 24, 2024 22:52
@artem-lunarg artem-lunarg requested a review from a team as a code owner September 24, 2024 22:52
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 263694.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17582 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17582 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 263745.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17583 running.

@artem-lunarg
tests: Simplify threading configuration
5fab55c 
When this test was introduced running time could vary 10x depending
on device. Reduce the number of threads to reduce threading
contention (but still keep high enough) with a hope to make CI running
time a bit less unpredictable.
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17583 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 263785.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17584 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17584 passed.

@artem-lunarg
Copy link
Contributor Author

The updated test takes around 4 seconds on internal CI Android devices.

@artem-lunarg artem-lunarg merged commit de3e5dc into KhronosGroup:main Sep 25, 2024
21 checks passed
@artem-lunarg artem-lunarg deleted the artem-update-threading-test branch September 25, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-lunarg spencer-lunarg spencer-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem-lunarg @ci-tester-lunarg @spencer-lunarg