Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #614

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Fix typo #614

merged 2 commits into from
Sep 8, 2024

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Sep 6, 2024

Allocation is for device USM, not shared USM.

Allocation is for device USM, not shared USM.
Comment on lines 12 to 13
// Allocate device global memory bound to the device and context associated
// with the queue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Allocate device global memory bound to the device and context associated
// with the queue
// Allocate device USM, using the device and context associated with the queue

We should use consistent terminology. Elsewhere in the spec we call this "device USM".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change made.

@gmlueck gmlueck added the editorial Some purely editorial problem label Sep 6, 2024
@gmlueck
Copy link
Contributor

gmlueck commented Sep 8, 2024

Merging as editorial

@gmlueck gmlueck merged commit 781e4fe into KhronosGroup:main Sep 8, 2024
2 checks passed
gmlueck added a commit to gmlueck/SYCL-Docs that referenced this pull request Sep 8, 2024
keryell pushed a commit that referenced this pull request Sep 10, 2024
gmlueck added a commit to gmlueck/SYCL-Docs that referenced this pull request Sep 14, 2024
Cherry pick KhronosGroup#614 from main
(cherry picked from commit 781e4fe)
@gmlueck gmlueck mentioned this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Some purely editorial problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants