-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update typescript-eslint dependency to v8 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules updates to come in isolated commits. Closes #354.
The rule that comes with ESLint now handles numeric separators, obsoleting the need for a TS-specific one. This rule has been deprecated in (though not yet removed from) upstream.
This rule was renamed in v6 to clarify what it does. With v8, the deprecated legacy alias has been removed.
- The Airbnb config has been moved to a peer dependency, so ESLint can resolve it in legacy configs without requiring users to manually install it. - The full Airbnb configs have been added as an optional peer dependency. - Since non-optional peer dependencies are installed by default, they have stopped being duplicated in the dev dependencies. - The ESLint dependency has been bumped to the latest minor version.
- Explicitly note the lack of ESLint 9 support, link to tracking ticket. - Provide flat configuration instructions (and recommend their use). - Update instructions for NPM v7 automatically installing peer dependencies. - Update configuration for use with typescript-eslint v8. - Some restructuring for readability. - Added instructions for removing formatting rules, since it's less simple with the ESLint stylistic rules (until the Prettier config gets updated). Closes #307
Kenneth-Sills
changed the title
Kesills typescript eslint v8
feat!: update typescript-eslint dependency to v8
Aug 25, 2024
🎉 This issue has been resolved in version 19.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from upstream PR.
This PR focuses on:
typescript-eslint
to the newest version and fixing up the rules for compatibility.typescript-eslint
, as well as modern usage of both NPM (peer dependencies) and ESLint (flat config via the compatibility dependency).There are some miscellaneous updates to our dependencies to make it work slightly better with NPM, as well as some updates to internal project configuration to make dogfooding the configuration work correctly.
These are 100% breaking changes and will require a major version increment.
Closes #1
Closes #2