Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh3 allow to share an entire customer #7

Merged
merged 36 commits into from
Aug 9, 2024
Merged

Gh3 allow to share an entire customer #7

merged 36 commits into from
Aug 9, 2024

Conversation

vazaha-nl
Copy link

Fixes #3

Lennart Hengstmengel added 25 commits July 29, 2024 16:49
db migration for customer sharing
cd016ce
set the project in timerecord model
276d405
renamed timesheet to project to reflect its purpose
ea2f3fb
template for timesheet for customer
acab803
update entity: add customer relation + type getter
b51fc1e
two separate forms, one for each type
ec54c21
add type column to index table
50ed27d
modify update/delete urls, we cannot use project_id anymore
b193051
correct links in action buttons
f1c144d
added submenu items to create button for each type
cf36c38
update index table template with extra col + correct urls
24669b1
more changes to handle the new type
30824fe
url for shared customer timesheets + refactor project view logic
672fe83
updates for stats per customer
cc8591e
fixes for phpstan errors
f7ea6e3
code style fixes
de8bb26
removed todo
ecdc982
added null check
63fd5e6
bugfix: limit to project
b1cc62a
bugfix: get correct currency
98a8d08
include stats for customer as well
ccd0633
partly fixed tests
cf4a4a0
whitespace
3ecf416
fix: rollback breaks if there are null values
641ac1d
code style fixes
00e075a
kevinpapst
kevinpapst requested changes Aug 8, 2024
View reviewed changes
Copy link
Member

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big PR.
I don't think I catched everything on this first round.
But it seems to work as expected, so that' very nice 👍

Model/TimeRecord.php Outdated Show resolved Hide resolved
Model/TimeRecord.php Outdated Show resolved Hide resolved
Controller/ManageController.php Outdated Show resolved Hide resolved
Entity/SharedProjectTimesheet.php Show resolved Hide resolved
Resources/views/manage/index.html.twig Outdated Show resolved Hide resolved
Entity/SharedProjectTimesheet.php Outdated Show resolved Hide resolved
Controller/ManageController.php Outdated Show resolved Hide resolved
Controller/ManageController.php Outdated Show resolved Hide resolved
Migrations/Version20240726082447.php Outdated Show resolved Hide resolved
@vazaha-nl
Copy link
Author

Good suggestions! I fixed them all.
Next time I will try to keep the PRs smaller but in this case it wasn't really possible, sorry for that.

kevinpapst
kevinpapst approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 LGTM

@kevinpapst kevinpapst merged commit 971e584 into Keleo:master Aug 9, 2024
3 checks passed
@kevinpapst kevinpapst added the enhancement New feature or request label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpapst kevinpapst kevinpapst approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to share an entire customer
2 participants
@vazaha-nl @kevinpapst