Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engines localization ru #2872

Merged
merged 19 commits into from
Jul 18, 2023
Merged

Conversation

Tagir-1
Copy link
Contributor

@Tagir-1 Tagir-1 commented Jun 26, 2023

  • I've added Russian localization file with translations of all currently existing engine descriptions from en-us-Engines.cfg. I have also added translator's notes for future contributors.
  • Additionally, I've fixed some typos I stumbled upon in en-us-Engines.cfg

Copy link
Member

@Capkirk123 Capkirk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why Soviet/Russian/Ukrainian rocket engine names are not translated? I don't see why they shouldn't be in Cyrillic, seeing as this is the Russian translation.

#roKTDU417Desc = КТДУ-417 (Корректирующе-тормозная двигательная установка) — посадочный двигатель аппаратов Луна 15 - Луна 24. Главный двигатель открытого цикла использовался для орбитального маневрирования и спуска, а затем переключался на дополнительный двигатель с вытеснительной подачей для конечного спуска. Используйте группы действий, чтобы быстро переключаться между основным и вспомогательным двигателями, чтобы упростить посадку.
// KTDU425A
#roKTDU425ATitle = KTDU-425
#roKTDU425ADesc = КТДУ-417 (Корректирующе-тормозная двигательная установка) — советский вакуумный двигатель открытого цикла на высококипящих компонетах. Предназначен для использования в двигательных установках космических аппаратов для Марса и Венеры серий 3МВ, 4МВ и 5МВ.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be КТДУ-425?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote in my notes:
"This is to keep engines sorted the way they are for better visual compatibility with English version, to make part search consistent and reliable and forum/discord help by other players easier."

I'm not entirely sure whether it's a good idea though. I would like to hear opinions of other people

@Capkirk123
Copy link
Member

Merging this. If other Russian-speaking players find untranslated names particularly annoying, it can be changed later

@Capkirk123 Capkirk123 merged commit 8fd1b94 into KSP-RO:master Jul 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants