Let ignoreMass, massOffset, etc work for bimodal engines #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO you should just change the original patch to target |
|
I'd worry about that catching things it shouldn't, but whatever maintainers think is best. (that is how it was handled for the new testflight system) |
|
I also support converting everything to |
|
I can change them all in this PR, but I won't test anything beyond what I've already tested |
lpgagnon
force-pushed
the
massoffset-bimodal
branch
from
381c605
to
dd5e44a
Compare
|
done. KSP-RO/ROEngines#188 still works with the switchover; no further testing done |
lpgagnon
changed the title
|
Tested, nothing obviously breaks. Should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2794