Delay execution of blink.js while document loads #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
approved these changes
May 25, 2023
|
Will this PR be merged? |
|
I practically forgot about this because I was just using my fork instead, but I haven't been working with Blink for a while anyway. I dropped a message in the gizmos channel on Slack so hopefully someone can have a look at these changes again soon. |
|
Thank you for taking the time to fix it. I am stuck with WebIO |
|
@pfitzseb Will you please tag a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the first window, I found that the callback for window creation was being executed quickly enough that the
initwebio!(w)method is triggered before the page has fully loaded (and hence beforewebioexists). Adding thedeferattribute to theblink.jsscript ensures it won't be executed until after the browser has had a chance to load in thewebio.bundled.jspackage.Fixes Blink.jl#300, WebIO.jl#505, and PlotlyJS.jl#460.