-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert flake to use haskell.nix #2600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigem
force-pushed
the
flake-haskell.nix
branch
4 times, most recently
from
April 12, 2021 08:54
8be92bd
to
7e6a370
Compare
jbgi
force-pushed
the
flake-haskell.nix
branch
4 times, most recently
from
April 22, 2021 13:53
017f3be
to
ca47543
Compare
jbgi
force-pushed
the
flake-haskell.nix
branch
2 times, most recently
from
April 27, 2021 12:01
8d099a1
to
09ff59e
Compare
craigem
requested review from
DavidEichmann,
dcoutts,
erikd,
Jimbo4350 and
newhoggy
as code owners
April 27, 2021 12:01
jbgi
force-pushed
the
flake-haskell.nix
branch
3 times, most recently
from
April 27, 2021 22:37
55a1900
to
8a9fa1c
Compare
jbgi
changed the title
WIP: Convert flake to use haskell.nix
Convert flake to use haskell.nix
Apr 27, 2021
jbgi
added
WIP
Work In Progress (cannot be merged yet)
nix
Nix-based build and CI infrastructure
labels
Apr 27, 2021
jbgi
force-pushed
the
flake-haskell.nix
branch
2 times, most recently
from
April 27, 2021 22:48
dbbb282
to
e71194a
Compare
craigem
commented
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy with this PR 😃
bors r+ |
👎 Rejected by label |
disassembler
approved these changes
Apr 28, 2021
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 28, 2021
2600: Convert flake to use haskell.nix r=disassembler a=craigem Convert the existing flake.nix to use the documented [example](https://input-output-hk.github.io/haskell.nix/tutorials/getting-started-flakes/) from [haskell.nix](https://github.com/input-output-hk/haskell.nix) as a basis. Depends on input-output-hk/iohk-nix#470 Should be import `./nix/haskell.nix` with some tweaks the `haskell.nix` to get the things it needs correctly. - [X] `nix build .` will build `cardano-node` by default. - [X] `nix build .#cardano-node` to be explicit - [X] `nix build .#cardano-cli` - [X] `nix build .#cardano-ping` - [X] `nix build .#db-converter` Specific system targets can be built, ie: ``` nix build .#packages.x86_64-darwin.cardano-node ``` A `nix repl` equivalent can be reached running: `nix run .#repl` ### ToDo: - [x] Import custom `libsodium` - [x] Import `nix/haskell.nix` - [x] Provide shortcuts so applications can be built as per the above examples, rather than as `"cardano-cli:exe:cardano-cli"` - [x] Provide builds for all Cardano networks. - [x] Fix `nix repl` (replaced - see above) - [x] Remove legacy Nix files Co-authored-by: Craige McWhirter <craige.mcwhirter@iohk.io>
newhoggy
approved these changes
Apr 28, 2021
craigem
force-pushed
the
flake-haskell.nix
branch
from
April 28, 2021 03:58
7b272b2
to
71587ac
Compare
Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
craigem
force-pushed
the
flake-haskell.nix
branch
from
April 28, 2021 04:04
71587ac
to
b3260b3
Compare
newhoggy
approved these changes
Apr 28, 2021
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the existing flake.nix to use the documented example from haskell.nix as a basis.
Depends on input-output-hk/iohk-nix#470
Should be import
./nix/haskell.nix
with some tweaks thehaskell.nix
to get the things it needs correctly.nix build .
will buildcardano-node
by default.nix build .#cardano-node
to be explicitnix build .#cardano-cli
nix build .#cardano-ping
nix build .#db-converter
Specific system targets can be built, ie:
A
nix repl
equivalent can be reached running:nix run .#repl
ToDo:
libsodium
nix/haskell.nix
"cardano-cli:exe:cardano-cli"
nix repl
(replaced - see above)