-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upload of a file in a shared Drive #1428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevincent
changed the title
Fix SharedWithMe upload
Fix upload of a file in a shared Drive
Sep 20, 2024
FabianDevel
requested changes
Sep 20, 2024
app/src/main/java/com/infomaniak/drive/ui/fileList/SelectFolderActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/ui/fileList/SelectFolderActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/ui/fileList/SelectFolderActivity.kt
Outdated
Show resolved
Hide resolved
sirambd
requested changes
Sep 20, 2024
app/src/main/java/com/infomaniak/drive/ui/fileList/SelectFolderActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/ui/fileList/SelectFolderActivity.kt
Outdated
Show resolved
Hide resolved
@sirambd Can you check where it makes sense to check for |
Let's start with another PR, as it will be a global refactor |
tevincent
force-pushed
the
fix-shared-upload
branch
5 times, most recently
from
September 26, 2024 12:12
f1651b5
to
d9c5bae
Compare
tevincent
force-pushed
the
fix-shared-upload
branch
from
September 26, 2024 12:18
d9c5bae
to
33168bd
Compare
KevinBoulongne
force-pushed
the
fix-shared-upload
branch
from
September 26, 2024 12:52
33168bd
to
d1ef263
Compare
tevincent
force-pushed
the
fix-shared-upload
branch
from
September 26, 2024 13:00
d1ef263
to
a999b4c
Compare
FabianDevel
approved these changes
Sep 26, 2024
KevinBoulongne
force-pushed
the
fix-shared-upload
branch
from
September 26, 2024 13:27
a999b4c
to
9b1a6ae
Compare
Quality Gate passedIssues Measures |
sirambd
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not working:
shared_not_working.mp4
Working:
shared_working.mp4