Avoid filling up save state bundle endlessly because of the ViewPager2 #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirambd
approved these changes
Jul 8, 2024
LunarX
force-pushed
the
prevent-viewpager2-transaction-too-large
branch
from
ffc3a29
to
650a535
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you scroll the preview viewpager a lot, the bundle that stores its state for when the view is recreated due to a configuration change increases endlessly. At some point the bundle can become too large and trigger a TransactionTooLargeException.
To avoid this, we can ask the ViewPager2 to not save its state for recreation and instead start over from a blank slate. This apparently doesn't remove any feature in our case and seems to be fixing the issue