Fix tab inserting the toString of objects instead of autocompletion when sharing folder #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyDL-Infomaniak
added
bug
KevinBoulongne
force-pushed
the
fix/tab-not-auto-completing-as-intended
branch
from
18c6f5c
to
84cc0ae
Compare
KevinBoulongne
requested changes
May 28, 2024
app/src/main/java/com/infomaniak/drive/ui/fileList/fileShare/AvailableShareableItemsAdapter.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
force-pushed
the
fix/tab-not-auto-completing-as-intended
branch
from
84cc0ae
to
2eca9e0
Compare
KevinBoulongne
requested changes
May 28, 2024
FabianDevel
requested changes
May 28, 2024
LunarX
requested changes
May 28, 2024
This has the same behavior as using tab. |
TommyDL-Infomaniak
force-pushed
the
fix/tab-not-auto-completing-as-intended
branch
from
03a1ff0
to
c7ed9d4
Compare
FabianDevel
approved these changes
May 28, 2024
KevinBoulongne
approved these changes
May 29, 2024
KevinBoulongne
force-pushed
the
fix/tab-not-auto-completing-as-intended
branch
from
7bf4904
to
50d2ee6
Compare
KevinBoulongne
force-pushed
the
fix/tab-not-auto-completing-as-intended
branch
from
50d2ee6
to
35f63f2
Compare
KevinBoulongne
force-pushed
the
fix/tab-not-auto-completing-as-intended
branch
from
45f79a5
to
9ea55cc
Compare
LunarX
approved these changes
May 30, 2024
KevinBoulongne
force-pushed
the
fix/tab-not-auto-completing-as-intended
branch
from
9ea55cc
to
83d3961
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is mostly solved, pressing tab will not insert the object toString anymore, but it will insert the current text, thus not changing anything.
A consequence of this is that the UI is refreshed and the list of users that was displayed gets closed.
This is the best solution found that does not require a refactor of the MaterialAutoCompleteTextView.