Fixes a bug where devices displaying an IOError state incorrectly r…

…eport as being online. Updates wiki regarding IOErrors.
IndigoDomotics · Oct 4, 2023 · f6447e0 · f6447e0
1 parent 8428989
commit f6447e0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/GhostXML.indigoPlugin/Contents/Info.plist b/GhostXML.indigoPlugin/Contents/Info.plist
@@ -3,7 +3,7 @@
 <plist version="1.0">
 <dict>
 	<key>PluginVersion</key>
-	<string>2022.3.2</string>
+	<string>2022.3.3</string>
 	<key>ServerApiVersion</key>
 	<string>3.2</string>
 	<key>IwsApiVersion</key>

diff --git a/GhostXML.indigoPlugin/Contents/Server Plugin/plugin.py b/GhostXML.indigoPlugin/Contents/Server Plugin/plugin.py
@@ -1294,10 +1294,20 @@ def refresh_data_for_dev(self, dev=None):
                         dev.updateStateOnServer('deviceIsOnline', value=False, uiValue='Error')
                         dev.updateStateImageOnServer(indigo.kStateImageSel.SensorTripped)
                         self.bad_calls += 1
-                    elif dev.states.get("Response", "") == "No data to return.":
+                    # 2023-10-04 DaveL17 - update to include XML parse error.
+                    elif dev.states.get("Response", "") in ["No data to return.", "Parse error. Check XML source."]:
                         dev.updateStateOnServer('deviceIsOnline', value=False, uiValue='Error')
                         dev.updateStateImageOnServer(indigo.kStateImageSel.SensorTripped)
                         self.bad_calls += 1
+                    # TODO: the following block can be deleted if the above block continues to run without errors.
+                    # elif dev.states.get("Response", "") == "No data to return.":
+                    #     dev.updateStateOnServer('deviceIsOnline', value=False, uiValue='Error')
+                    #     dev.updateStateImageOnServer(indigo.kStateImageSel.SensorTripped)
+                    #     self.bad_calls += 1
+                    # elif dev.states.get("Response", "") == "Parse error. Check XML source.":
+                    #     dev.updateStateOnServer('deviceIsOnline', value=False, uiValue='Error')
+                    #     dev.updateStateImageOnServer(indigo.kStateImageSel.SensorTripped)
+                    #     self.bad_calls += 1
                     else:
                         dev.updateStateOnServer('deviceIsOnline', value=True, uiValue="Updated")
                         self.logger.info(f"{dev.name} updated.")

diff --git a/_changelog.md b/_changelog.md
@@ -1,3 +1,6 @@
+### v2022.3.3
+- Fixes a bug where devices displaying an `IOError` state incorrectly report as being online.
+
 ### v2022.3.2
 - Bumps version number.