-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(form-mixin): Refactor form components for native behavior alignment #1389
base: master
Are you sure you want to change the base?
Conversation
…ignment - Aligned form components to mimic native counterparts when setting `value`/`checked` states via `setAttribute()`, ensuring internal `defaultValue` is updated accordingly. - Removed obsolete code. - Consolidated code into a more efficient API. - Renamed internal methods for clarity.
…xin-default-value
Added internal defaultValue and defaultChecked.
…xin-default-value
Added API docs for form mixins
@wnvko |
@radomirchev <form action="">
<igc-rating name="my-rating"></igc-rating>
<igc-button type="reset">Reset</igc-button>
</form> If I choose some value and then click reset button nothing happens - rating retains its value. This bug does not happen if rating has initial value, or if rating is |
@wnvko |
value
/checked
states viasetAttribute()
, ensuring internaldefaultValue
is updated accordingly.Closes #1386