Custom response parameters for custom grants #3137

[szymongaertig]

implementation of custom response parameters for custom grants

[dnfclas]

Hi @garfieldos, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

[leastprivilege]

Can you sign the CLA?

[dnfclas]

@garfieldos, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

[szymongaertig]

Done :)

[leastprivilege]

This has a problem

we need a comination of

https://github.com/IdentityServer/IdentityServer4/blob/dev/src/IdentityServer4/Infrastructure/ObjectSerializer.cs

and

https://github.com/IdentityServer/IdentityServer4/blob/dev/src/IdentityServer4/Extensions/DictionaryExtensions.cs

[szymongaertig]

https://github.com/IdentityServer/IdentityServer4/blob/dev/src/IdentityServer4/Infrastructure/ObjectSerializer.cs#L24
Why I should use this class?
In this implementation ToString method returns JsonConvert.SerializeObject(o, settings); instead of JsonSerializer.Serialize (this same sytuation in method ToObject).

[leastprivilege]

Because you want to ignore null values

[szymongaertig]

Right.
Fixed in 437cebf

[szymongaertig]

I will close this PR because of new #3191