Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list_devices: prints serial when discovering ppk2 #43

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

wlgrd
Copy link
Collaborator

@wlgrd wlgrd commented Apr 18, 2024

This commit adds an extra field to the return from list_devices with the serial number of the discovered device. Added printing of the serial in the examples, as requested in #41.

Output from example.py

> py example.py
Found PPK2 at /dev/ttyACM0 with serial number C10A56B6
Average of 512 samples is: -1.3063051170568183uA
[1, 1, 1, 1, 1, 1, 1, 1, 1, 1]
[1, 1, 1, 1, 1, 1, 1, 1, 1, 1]
(...)

@wlgrd wlgrd mentioned this pull request Apr 18, 2024
@wlgrd wlgrd marked this pull request as draft April 18, 2024 13:11
@wlgrd
Copy link
Collaborator Author

wlgrd commented Apr 18, 2024

Converting to draft as it is not fixed for windows yet

@wlgrd wlgrd marked this pull request as ready for review April 18, 2024 13:17
@wlgrd wlgrd requested a review from NejcKle April 24, 2024 06:29
@wlgrd wlgrd merged commit 8c9459d into master Jul 25, 2024
@wlgrd wlgrd deleted the add_sn_to_discovery branch July 25, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants