Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify publishing of minutes #2

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

tpluscode
Copy link

This PR brings a number of improvements to the way minutes are published

  1. Simplification of steps necessary
    • mostly automatic, check readme.md
    • reduced boilerplate
  2. site published using Jekyll (static, no PHP)
    • easiest way to deploy using Netlify which also publishes PR previews

@lanthaler, to complete this, we'll need the domain DNS settings panel. Do you have it personally registered or through an account you can share with us?

@tpluscode
Copy link
Author

@alien-mcl please squash-merge

@tpluscode
Copy link
Author

Check tpluscode/pull/1 to see Netlify's auto-deploy in action of our latest meeting

@alien-mcl
Copy link
Member

I was wondering - is it possible to publish these via GHPages?

@tpluscode
Copy link
Author

Yes, but why would you do that? ;) To get gh-pages we'd need a more elaborate setup

  • CI building and pushing to gh-pages branch
  • building manually and pushing the result (i.e. no automation)

Netlify is really cool, being fully automatic and let's you run scripts. Supports Ruby, node, Python. anything we may need to automate. And you get the PR preview too.

@lanthaler
Copy link
Member

Please make sure that the previous minutes that you delete in this PR are regenerated in the same way. I doubt that all of them do as the IRC log was not always clean and thus some of the minutes required post-processing.

Due to that, I'm also a bit skeptical that bringing Jekyll etc. is really an improvement to just having to paste the IRC log into http://www.hydra-cg.com/minutes/scribetool, massage it till it looks correct (attendee list, topics, resolutions etc.) and then copy it into a file and submit it. Just my experience, feel free to choose whatever works best for you guys.

Last but not least, I can't simply point the domain to another IP till everything is hosted there. So you need to put the site itself (/), the spec (/spec/), and the minutes (/minutes/) on a single host. We should definitely not break everyone's links.

@tpluscode
Copy link
Author

Please make sure [..]

I did not verify each individual resulting HTML. I can undelete them to check and adjust the IRC logs as needed. Once we get the desired result I would still propose to remove them as they would be getting rewritten by the script.

Do check the online preview too: https://deploy-preview-1--xenodochial-cori-b4fe5c.netlify.com

I'm also a bit skeptical that bringing Jekyll etc.

Jekyll is not mandatory. You could use any other static site generator. The benefits are: markdown, shared page layout instead of duplication, and page metadata, which is then used on the main page.

Not sure about "etc" 😉

[..] is really an improvement [..]

So the current algorithm is as follows:

  1. paste the IRC log into scribetool
  2. massage it till it looks correct (you would typically "massage" the HTML?)
  3. copy it into a file
  4. submit it

Using some automation the only step necessary is to commit the IRC log to date folder. Much less opportunity for error (like the date thing you noticed when Karol submitted his first PR). Also, with Netlify we an get instant preview like the one linked above.

Last but not least, I can't simply point the domain to another IP till everything is hosted there.

The easiest way is to move the stuff hosted separately to subdomains. This here could become minutes.hydra-cg.com, redirected from the current path so that links don't break.

Other option would be consolidate the repos somehow but I think it's too much hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants