Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctrine repository find() methods not always returning the correct type hints #1434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jackbentley
Copy link

I'm not entirely sure how these classes/extension points work and I don't normally code in Java let alone IntelliJ plugins - but this seems to be working for me 🤷‍♂ .

It seems like it wasn't resolving class references correctly. Stripping the class identifiers in the signature solves it so the getSignature() method can find the PHP class and return it as a type hint.

Code review would be appreciated as I don't really know what I'm doing 😂

Potential fix for #1422

@jackbentley
Copy link
Author

After using this build it looks like it doesn't fix the duplicate return type issue as explained in #1422 but it does solve the issue I was referring to in my comment on that issue.

@jackbentley
Copy link
Author

I believe the latest commit now fixes #1422 :)

Copy link

@skmedix skmedix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused imports of PhpTypeProvider3

@Haehnchen
Copy link
Owner

thanks for this PR, will also comeback here, fixing lost features for API changes ;)

@Lustmored
Copy link
Contributor

Is there any help needed with this PR? Can we do anything to speed up merging and publishing it?

This issue is becoming more and more annoying and fix would be very welcome :)

Also I think it would fix issues reappearing in #1401

@auipga
Copy link

auipga commented Oct 31, 2020

I didn't review, but this really needs attention
@Haehnchen ping (please pm me your paypal.me/user/50 if this would help you and to show you my gratitude)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants