Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FRF noise covariance calculation library #977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mwilensky768
Copy link

@mwilensky768 mwilensky768 commented Sep 26, 2024

This branch adds some noise propagation functions for the fringe rate filter + coherent averaging steps.

I've added the basic functions that are demonstrated in the single baseline power spectrum notebook, though they've been modified here to be slightly more general since the notebook versions used notebook-specific info. This PR and the corresponding one on that repo should probably coordinate.

I still need to add unit tests and think I should add a wrapper that goes from ee + nn autos/crosses all the way to a pI time-time cov. per freq so that there is a clearly implemented "pipeline" somewhere, though maybe that should just live in another repo as part of actual pipeline code.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 12.67606% with 62 lines in your changes missing coverage. Please review.

Project coverage is 96.62%. Comparing base (0529798) to head (e6d8dca).

Files with missing lines Patch % Lines
hera_cal/frf.py 8.95% 61 Missing ⚠️
hera_cal/noise.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   97.16%   96.62%   -0.54%     
==========================================
  Files          31       31              
  Lines       11064    11133      +69     
==========================================
+ Hits        10750    10757       +7     
- Misses        314      376      +62     
Flag Coverage Δ
unittests 96.62% <12.67%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant