Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lstcal with multiple bands #958

Merged
merged 4 commits into from
Jul 3, 2024
Merged

fix: lstcal with multiple bands #958

merged 4 commits into from
Jul 3, 2024

Conversation

steven-murray
Copy link
Contributor

Fixes issues found when running lststack notebook with new calibration / inpainting code in hera-cal.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (1858df5) to head (fa2cf89).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
- Coverage   97.27%   97.27%   -0.01%     
==========================================
  Files          31       31              
  Lines       10951    10950       -1     
==========================================
- Hits        10653    10652       -1     
  Misses        298      298              
Flag Coverage Δ
unittests 97.27% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-murray steven-murray marked this pull request as ready for review July 3, 2024 15:22
@steven-murray steven-murray self-assigned this Jul 3, 2024
Copy link
Contributor

@tyler-a-cox tyler-a-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix @steven-murray!

@tyler-a-cox tyler-a-cox merged commit 3ca93b4 into main Jul 3, 2024
10 of 11 checks passed
@tyler-a-cox tyler-a-cox deleted the fix-lstcal branch July 3, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants