Basic ruff #956
Merged
Basic ruff #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 30 30
Lines 10795 10795
=======================================
Hits 10500 10500
Misses 295 295
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsdillon
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps out out flake8 checks for the same checks with
ruff(to the extent possible). This is faster, and also allows them to be auto-fixed at pre-commit time. I am not currently runningruff format, which would result in black-like formatting (we could decide to add that at a later time if we want), only doing the flake8 checks/fixes. I ran the checks on the entire code-base and made all necessary fixes.I also deleted the
calibrations/sub-folder as it wasn't being imported or used anywhere in the code. It's possible that it's being used from outside the code in some pipeline, in which case I'll put it back in.