improve handling for future pyuvdata #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the thing that matters -- the function signature. Fixes tests on pyuvdata PRs preparing for version 3.0
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
=======================================
Coverage 97.18% 97.18%
=======================================
Files 23 23
Lines 10444 10446 +2
=======================================
+ Hits 10150 10152 +2
Misses 294 294
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small tweak to ensure that hera_cal tests pass on the branch we're using to prepare for version 3.0. Since we haven't reached v3.0 yet the desired code branch isn't being used. This fixes the code to look at the actual function signature rather than the pyuvdata version so the correct branch is used.
The coverage issue is because CI is only running against current pyuvdata versions.