Fix build_fringe_rate_profiles bug when number of pols = 1
#903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aewallwi Not asking you for a review (I know you're busy!) but I thought I'd just flag this for you in case you were curious or if it impacted H4C analysis (I doubt it). |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
- Coverage 97.20% 97.15% -0.06%
==========================================
Files 21 23 +2
Lines 9455 10262 +807
==========================================
+ Hits 9191 9970 +779
- Misses 264 292 +28
☔ View full report in Codecov by Sentry. |
tyler-a-cox
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Seems like a pretty straightforward fix, approved. Thanks @jsdillon!
|
Thanks for keeping me in the loop @jsdillon! This all looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug where
.squeeze(), which is designed to eliminate extraneous dimensions in pyuvdata objects, can also squeeze out dimensions in theflag_arraywhen the number of polarizations is 1. This PR prevents that by first doing a np.all over the polarization axis, as was intended, then squeezing (which does nothing whenfuture_array_shapes == True).This PR also fixes a bunch of pep8 stuff.