Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump csharpier from 0.29.1 to 0.29.2 #27

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps csharpier from 0.29.1 to 0.29.2.

Release notes

Sourced from csharpier's releases.

0.29.2

What's Changed

Comments don't follow tabs indent style #1343

Prior to 0.29.2 CSharpier was converting any tabs within the block of a multiline comment to spaces.

public void SomeFunction()
{
	/*
	The following line is an example with an indent:
		This line is indented by one tab. (prior to 0.29.2 this would end up as a tab followed by 4 spaces)
	*/
	/*
	The following line is an example with an indent:
		This line is indented by 4 spaces but will be converted to 1 tab (prior to 0.29.2 this would end up as a tab followed by 4 spaces)
	*/
	/*
	The following line is an example with an indent:
	   This line is indented by 3 spaces but will be left as 3 spaces
	*/
}

csharpier-ignore-start now supported in object initializers #1342

// input & expected output
return new SomeClass
{
    // csharpier-ignore-start
    SomeProperty =     someValue,
    SomeProperty2 =     someValue
    // csharpier-ignore-end
};
// 0.29.1
return new SomeClass
{
// csharpier-ignore-start
SomeProperty = someValue,
SomeProperty2 = someValue
// csharpier-ignore-end
};

Fixed extra new line between cast and collection expression. #1334

// input & expected output
CallMethod(
    (string[])
        [
            longerValue_____________________________________________,
            longerValue_____________________________________________,
</tr></table> 

... (truncated)

Changelog

Sourced from csharpier's changelog.

# 0.29.2

What's Changed

Comments don't follow tabs indent style #1343

Prior to 0.29.2 CSharpier was converting any tabs within the block of a multiline comment to spaces.

public void SomeFunction()
{
	/*
	The following line is an example with an indent:
		This line is indented by one tab. (prior to 0.29.2 this would end up as a tab followed by 4 spaces)
	*/
	/*
	The following line is an example with an indent:
		This line is indented by 4 spaces but will be converted to 1 tab (prior to 0.29.2 this would end up as a tab followed by 4 spaces)
	*/
	/*
	The following line is an example with an indent:
	   This line is indented by 3 spaces but will be left as 3 spaces
	*/
}

csharpier-ignore-start now supported in object initializers #1342

// input & expected output
return new SomeClass
{
    // csharpier-ignore-start
    SomeProperty =     someValue,
    SomeProperty2 =     someValue
    // csharpier-ignore-end
};
// 0.29.1
return new SomeClass
{
// csharpier-ignore-start
SomeProperty = someValue,
SomeProperty2 = someValue
// csharpier-ignore-end
};

Fixed extra new line between cast and collection expression. #1334

// input & expected output
CallMethod(
    (string[])
        [
            longerValue_____________________________________________,
            longerValue_____________________________________________,
</tr></table> 

... (truncated)

Commits
  • 57c3ca1 Releasing 0.29.2 (#1347)
  • 861f281 Support custom file extensions with editor config (#1346)
  • e90022e fixing issue when formatting with tabs that would convert tabs in com… (#1344)
  • 3fd7faa Adding support for csharpier-ignore-start in object initializers (#1345)
  • 8bca3ce fixing issue with extra line before collection expression within a ca… (#1335)
  • 4d51407 Tweak the logic around validating installs so it doesn't bomb out and… (#1339)
  • 12fb058 Possible fix for issue on osx (#1338)
  • 90c6c28 proper indent size
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [csharpier](https://github.com/belav/csharpier) from 0.29.1 to 0.29.2.
- [Release notes](https://github.com/belav/csharpier/releases)
- [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md)
- [Commits](belav/csharpier@0.29.1...0.29.2)

---
updated-dependencies:
- dependency-name: csharpier
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 16, 2024

The following labels could not be found: nuget, .NET, packages, dependencies.

Copy link

korbit-ai bot commented Sep 16, 2024

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

Hi there! 👋 Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

Copy link

semanticdiff-com bot commented Sep 16, 2024

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Filename Status
✔️ .config/dotnet-tools.json Analyzed

Copy link

gooroo-dev bot commented Sep 16, 2024

Please double check the following review of the pull request:

Issues counts

🐞Mistake 🤪Typo 🚨Security 🚀Performance 💪Best Practices 📖Readability ❓Others
0 0 0 0 0 0 0

Changes in the diff

  • 🛠️ Bumped the version of csharpier from 0.29.1 to 0.29.2.

Identified Issues

No issues were found in the proposed changes. The version bump appears straightforward and does not introduce any new code or features that could be problematic.

Missing Tests

No new tests are needed for this change as it is simply a version bump for a tool dependency.

Summon me to re-review when updated! Yours, Gooroo.dev
Please add a reaction or reply with your thoughts!

Copy link

pr-code-reviewer bot commented Sep 16, 2024

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior:

  1. .config/dotnet-tools.json:
    • The version of the tool csharpier has been updated from "0.29.1" to "0.29.2". While this may seem like a minor update, it can potentially introduce new bugs or behavior changes that were not present in the previous version. It's important to validate the compatibility and any breaking changes that might affect the project.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency:

  1. .config/dotnet-tools.json:
    • Whenever updating tools or dependencies, it's recommended to check the changelogs or release notes of the new versions to understand any breaking changes, new features, bug fixes, or performance improvements that might affect the project. This proactive approach can help mitigate unexpected issues arising from the update.

Copy link

instapr bot commented Sep 16, 2024

Feedback for Pull Request:

  • Updated csharpier from 0.29.1 to 0.29.2.
  • No conflicts found.

The patch looks good. 🚀

Copy link
Contributor

deepsource-io bot commented Sep 16, 2024

Here's the code health analysis summary for commits b8695c1..239b13e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource C# LogoC#✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateC#
Branch Coverage100%100%
Composite Coverage0%0%
Line Coverage0%0%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

coderabbitai bot commented Sep 16, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@guibranco guibranco enabled auto-merge (squash) September 16, 2024 14:13
@gstraccini gstraccini bot added the ☑️ auto-merge Auto merge enabled by gstraccini-bot label Sep 16, 2024
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Issue/Pull request created by bot label Sep 16, 2024
@guibranco
Copy link
Member

@dependabot squash and merge

Copy link

Infisical secrets check: ✅ No secrets leaked!

Scan results:

2:14PM INF scanning for exposed secrets...
2:14PM INF 19 commits scanned.
2:14PM INF scan completed in 65ms
2:14PM INF no leaks found

@guibranco guibranco merged commit a91112b into main Sep 16, 2024
12 checks passed
@guibranco guibranco deleted the dependabot/nuget/csharpier-0.29.2 branch September 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Auto merge enabled by gstraccini-bot 🤖 bot Issue/Pull request created by bot size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant