Add sacks, baskets, essence pouches and other storage items

[GregHib]

Storage items #397

• Vegetable sacks
• Fruit baskets
• Tea flask
• Food satchels
• Runecrafting pouches
• Coal bag
• Gem bag

Misc:

• Added fletching tests Fletching #486
• Added set charge operator Item degrading & charges #311
• Added drop and destroy item events
• Added more item-on-item-tests

[github-actions]

Qodana Community for JVM

1 new problem were found

Inspection name	Severity	Problems
Unused symbol	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[codecov]

Codecov Report

Attention: Patch coverage is 60.96718% with 226 lines in your changes are missing coverage. Please review.

Project coverage is 33.11%. Comparing base (fde0d64) to head (03ad4fe).
Report is 1 commits behind head on main.

❗ Current head 03ad4fe differs from pull request most recent head dbbd370. Consider uploading reports for the commit dbbd370 to get more accurate results

Additional details and impacted files

Files	Coverage Δ
...d/interact/entity/player/combat/consume/Consume.kt	77.77% <100.00%> (+7.77%)	⬆️
...ld/interact/entity/player/equip/InventoryOption.kt	90.32% <100.00%> (+1.86%)	⬆️
...voidps/engine/inv/restrict/ValidItemRestriction.kt	22.22% <0.00%> (ø)
.../voidps/engine/inv/transact/operation/SetCharge.kt	92.85% <92.85%> (ø)
...voidps/world/interact/entity/item/ItemDropping.kts	56.25% <60.00%> (+1.70%)	⬆️
.../voidps/world/interact/entity/item/Destructible.kt	66.66% <66.66%> (ø)
...gregs/voidps/world/interact/entity/item/Dropped.kt	66.66% <66.66%> (ø)
.../voidps/world/interact/entity/item/ItemDestroy.kts	65.00% <70.00%> (+53.23%)	⬆️
...rld/gregs/voidps/engine/inv/InventoryOperations.kt	5.88% <0.00%> (-0.64%)	⬇️
...egs/voidps/world/interact/entity/item/Destroyed.kt	33.33% <33.33%> (ø)
... and 9 more

... and 13 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #526      +/-   ##
============================================
+ Coverage     32.49%   33.11%   +0.62%     
- Complexity     4540     4581      +41     
============================================
  Files          1243     1254      +11     
  Lines         39980    40543     +563     
  Branches       8480     8615     +135     
============================================
+ Hits          12991    13426     +435     
- Misses        24096    24118      +22     
- Partials       2893     2999     +106     

Components	Coverage Δ
Content	24.83% <62.61%> (+1.38%)	⬆️
Engine	44.18% <36.11%> (-0.03%)	⬇️
Network	71.28% <ø> (+0.03%)	⬆️

[jarryd229]

i just did the quest and got a tea flask and satchel

here are the right messages

tea flask

inventoryItem("Drink", "tea_flask") {
player.message("There's nothing left in the flask.")

player.playAnimation("5827")
player.message("You take a drink from the flask...")

inventoryItem("Look-in", "tea_flask") {
item("tea_flask", 400, "There is no tea in this flask.")
item("tea_flask", 400, "There is one serving of tea in this flask.")
item("tea_flask", 400, "There is 2 serving of tea in this flask.")
item("tea_flask", 400, "There is 3 serving of tea in this flask.")
item("tea_flask", 400, "There is 4 serving of tea in this flask.")
item("tea_flask", 400, "There is 5 serving of tea in this flask.")

itemOnItem("cup_of_tea", "tea_flask") { player ->
player.message("You add the tea to the flask.")
player.message("The flask is full!")

itemOnItem("tea_flask", "empty_cup") { player ->
player.message("You fill the cup with tea.")

satchel i only can get rune because im only level 11 combat i think there all the same

inventoryItem("Inspect", "*_satchel") {
item("_satchel", 400, "The rune satchel!
(empty)")
item("_satchel", 400, "The rune satchel!
(Containing: no sandwich, one cake, and one banana)")
item("_satchel", 400, "The rune satchel!
(Containing: one sandwich, no cake, and no banana)")
item("_satchel", 400, "The rune satchel!
(Containing: one sandwich, no cake, and one banana)")
item("_satchel", 400, "The rune satchel!
(Containing: one sandwich, one cake, and one banana)")

itemOnItem("cake", "*_satchel") { player ->
player.message("You already have a cake in there.")

itemOnItem("banana", "*_satchel") { player ->
player.message("You already have a banana in there.")

itemOnItem("triangle_sandwich", "*_satchel") { player ->
player.message("You already have a sandwich in there.")

with sacks and basket with
when (player.inventory.transaction.error) {
i don't get any message when i don't have any potatoes in my inv and i have a potatoes sack 6

[GregHib]

here are the right messages

You star! Do you happen to know if the functionality of emptying the satchel is correct? I guessed that it tries to withdraw as many as possible vs fails to withdraw unless you have X number of spaces.

i don't get any message when i don't have any potatoes in my inv and i have a potatoes sack 6

Yeah that's what I had in my notes but I wanted to double check, thanks.

[jarryd229]

the satchel can only hold one of ea item if the Inventory is full you get this message 3 times
"You don't have enough free space to empty your satchel."
if you have 1 space in your Inventory you will get the banana and the message 2 times
if you have 2 spaces free you get banana and the cake and 1 message