[Fixes #12594] Error when saing a new map

geonode/base/api/serializers.py

@@ -737,8 +737,8 @@ def to_internal_value(self, data):
 
     def update(self, instance, validated_data):
         user = self.context["request"].user
-        for field in user.APPROVAL_STATUS_FIELDS:
-            if not user.can_change_resource_field(instance, field) and field in user.APPROVAL_STATUS_FIELDS:
+        for field in instance.ROLE_BASED_MANAGED_FIELDS:
+            if not user.can_change_resource_field(instance, field) and field in validated_data:
                 validated_data.pop(field)
         return super().update(instance, validated_data)
 
@@ -760,7 +760,7 @@ def save(self, **kwargs):
             instance.set_bbox_polygon(coords, srid)
 
         user = self.context["request"].user
-        for field in user.APPROVAL_STATUS_FIELDS:
+        for field in instance.ROLE_BASED_MANAGED_FIELDS:
             if not user.can_change_resource_field(instance, field):
                 logger.debug("User can perform the action, the default value is set")
                 setattr(user, field, getattr(ResourceBase, field).field.default)

geonode/base/models.py

@@ -632,6 +632,9 @@ class ResourceBase(PolymorphicModel, PermissionLevelMixin, ItemBase):
     Base Resource Object loosely based on ISO 19115:2003
     """
 
+    # fixing up the publishing option based on user permissions
+    ROLE_BASED_MANAGED_FIELDS = ["is_approved", "is_published", "featured"]
+
     BASE_PERMISSIONS = {
         "read": ["view_resourcebase"],
         "write": ["change_resourcebase_metadata"],

geonode/people/models.py

@@ -151,9 +151,6 @@ def class_name(value):
     objects = ProfileUserManager()
     USERNAME_FIELD = "username"
 
-    # fixing up the publishing option based on user permissions
-    APPROVAL_STATUS_FIELDS = ["is_approved", "is_published", "featured"]
-
     def group_list_public(self):
         return GroupProfile.objects.exclude(access="private").filter(groupmember__user=self)