Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Clinical trials lookup function #52
feat: Clinical trials lookup function #52
Changes from all commits
7d9614f
10ab373
eeef142
a45c4f0
c94bdc3
1a30322
68eac98
5864b52
844eec7
6d6d069
bb5f5eb
5542606
8a8bef9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any guarantees about what form a given term takes? are we hoping that the label provided by the normalizer is the term used by the trial? I just tried imatinib vs gleevec and I think they are both returning the same results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In its current state, yes just essentially hoping that the label the normalizer gives is the correct search term to use. I imagine whether or not it works on clinical trials end (i.e. imatinib vs gleevec) will be determined by how well the clinical trial entries themselves have been tagged/organized for the appropriate interventions? The imatinib and gleevec example I can see someone remembering to associate both of those names with any clinical trial just because its so well studied, but maybe this isn't always the case and maybe some aliases will differ in results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the story here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I wonder if we can reduce the size of the response with the
fields
param in case there's anything that we aren't usingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://clinicaltrials.gov/data-api/api#:~:text=Studies-,Studies,-Returns%20data%20of
ClinicalTrials.gov api allows you to submit a bunch of different parameter types through the Studies API. For this implementation, I just had the Studies API as the base URL then wanted to leave room for constructing more specific queries if needed just by adding strings together basically. So intr_url corresponds to the query.intervention parameter, but I could also see a world where someone is also interested in supplying the query.condition parameter, or maybe just additional terms as a parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, just have the intr_url working.
All this being said, if there is a better way to do this I am all open for it