Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add chainfile argument to Converter #26

Merged
merged 2 commits into from
Feb 2, 2024
Merged

feat: add chainfile argument to Converter #26

merged 2 commits into from
Feb 2, 2024

Conversation

korikuzma
Copy link
Member

close #22

Changes:

  • Adds chainfile argument to Converter so that we can point to local file and not have to make any calls to wags-tails
  • I removed type checks for to_db and from_db since the signature states they should be of type Genome

@korikuzma korikuzma added enhancement New feature or request priority:high High priority labels Feb 1, 2024
@korikuzma korikuzma self-assigned this Feb 1, 2024
@korikuzma korikuzma merged commit 7e52275 into main Feb 2, 2024
14 checks passed
@korikuzma korikuzma deleted the issue-22 branch February 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
enhancement New feature or request priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow option for Converter to not use wags-tails to get chain file
2 participants
@korikuzma @jsstevenson