enhancement: add edge case error handling #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
requested review from
korikuzma
and removed request for
korikuzma
korikuzma
previously approved these changes
Jan 18, 2024
tests/test_liftover.py
Outdated
Comment on lines
10
to
11
| assert result | ||
| assert len(result) == 1 |
There was a problem hiding this comment.
For these, we could just stick with checking the len == 1
Suggested change
| assert result | |
| assert len(result) == 1 | |
| assert len(result) == 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12
unwrap()is sort of like choosing to ignore possible errors. There are a couple cases where it's prudent/not burdensome to catch those errors (usinglet-elsehttps://doc.rust-lang.org/rust-by-example/flow_control/let_else.html) and a couple where I think it's fine (errors come from using a different kind of value than what we're calling it with)