-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split web server into separate package #98
Open
josephmckinsey
wants to merge
16
commits into
main
Choose a base branch
from
jm/split_web
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
josephmckinsey
commented
May 24, 2024
•
edited
Loading
edited
- Eliminated npm part in setup.py commands
- Created separate package
- rename to helics_cli_extras
- move observer stuff to helics_cli_extras
- move testing if necessary
- setup ci
- setup cd and PyPI package (🤞)
- Changed CI to run on push to main or pull request to main (prevents annoying duplication)
- Eliminated npm part in setup.py commands - Created separate package TODO - rename to helics_cli_extras - move observer stuff to helics_cli_extras - move testing if necessary - setup ci/cd and PyPI package
Relates to #86 For configuring the CI/CD workflow for this with PyPI publishing, use:
|
For backlog to make sdist eventually work: a custom in-source tree build backend interface that runs npm commands would likely be what we want. |
nightlark
reviewed
Jul 19, 2024
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
P.S. I had to remove the python package "install" that was being added to our python dependencies in the github actions workflow. I believe it was never intended to be installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.