Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split web server into separate package #98

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

josephmckinsey
Copy link
Contributor

@josephmckinsey josephmckinsey commented May 24, 2024

  • Eliminated npm part in setup.py commands
  • Created separate package
  • rename to helics_cli_extras
  • move observer stuff to helics_cli_extras
  • move testing if necessary
  • setup ci
  • setup cd and PyPI package (🤞)
  • Changed CI to run on push to main or pull request to main (prevents annoying duplication)

- Eliminated npm part in setup.py commands
- Created separate package

TODO
- rename to helics_cli_extras
- move observer stuff to helics_cli_extras
- move testing if necessary
- setup ci/cd and PyPI package
@nightlark
Copy link
Member

nightlark commented May 24, 2024

Relates to #86

For configuring the CI/CD workflow for this with PyPI publishing, use:

Repository: [GMLC-TDC/pyhelics](https://github.com/GMLC-TDC/pyhelics)
Workflow: cd-cli-extras.yml
Environment name:        pypi-cli-extras

@nightlark
Copy link
Member

For backlog to make sdist eventually work: a custom in-source tree build backend interface that runs npm commands would likely be what we want.

@josephmckinsey josephmckinsey marked this pull request as ready for review June 7, 2024 17:54
josephmckinsey and others added 2 commits July 24, 2024 09:24
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@josephmckinsey
Copy link
Contributor Author

P.S. I had to remove the python package "install" that was being added to our python dependencies in the github actions workflow. I believe it was never intended to be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants