Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

87 missing shname und shproperty in properties with shnode #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MircoNierenz
Copy link
Contributor

@MircoNierenz MircoNierenz commented Sep 8, 2024

Description

add name and description to groups for all shacls

Type of change

Please delete options that are not relevant.

  • New type (non-breaking change which adds a type)
  • Change (non-breaking change or fix on an existing type)
  • Breaking change (Change that would cause existing Self Descriptions not to be accepted anymore by a Federated Catalogue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any
relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • My code follows the modelling guidelines of this project
  • I have performed a self-review of my own changes

MircoNierenz and others added 2 commits September 8, 2024 15:30
Signed-off-by: GitHub Action <justin.dex@msg-david.de>
Copy link
Collaborator

@robertschubert robertschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review remarks.
After this we need a merge from master or rebase to resolve the conflicts

sh:order 2 ;
sh:path surface-model:Format ],
[ sh:maxCount 1 ;
sh:minCount 1 ;
sh:node surface-model:DataShape ;
sh:name "DataObject" ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be lower case as the other sh:name fields

@@ -9,31 +9,43 @@ environment-model:EnvironmentModelShape a sh:NodeShape ;
sh:property [ sh:maxCount 1 ;
sh:minCount 1 ;
sh:node general:GeneralShape ;
sh:name "generalObject" ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the "Object" suffix in each and every sh:name field?
There are other examles like in scenario_shacl.ttl:

[ skos:example "http://mywebsite.de/map.xodr" ;
            sh:description "Link to traffic space"@en ;
            sh:maxCount 1 ;
            sh:message "Validation of trafficSpace failed!"@en ;
            sh:minCount 0 ;
            sh:name "trafficSpace"@en ;
            sh:node general:LinkShape ;
            sh:order 2 ;
            sh:path scenario:trafficSpace ] ;

I would prefer to have it comparable to the other name fields.

BTW: sh:name can be even a speaking token, e. g. gx_shacl.ttl:

[ sh:description "a resolvable link to the participant self-description legally enabling the data usage." ;
            sh:maxCount 1 ;
            sh:minCount 1 ;
            sh:name "produced by" ;
            sh:node gx:LegalParticipant ;
            sh:nodeKind sh:IRI ;
            sh:order 2 ;
            sh:path gx:producedBy ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing sh:name und sh:property in properties with sh:node
4 participants