-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
87 missing shname und shproperty in properties with shnode #98
base: main
Are you sure you want to change the base?
87 missing shname und shproperty in properties with shnode #98
Conversation
Signed-off-by: GitHub Action <justin.dex@msg-david.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See review remarks.
After this we need a merge from master or rebase to resolve the conflicts
sh:order 2 ; | ||
sh:path surface-model:Format ], | ||
[ sh:maxCount 1 ; | ||
sh:minCount 1 ; | ||
sh:node surface-model:DataShape ; | ||
sh:name "DataObject" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be lower case as the other sh:name fields
@@ -9,31 +9,43 @@ environment-model:EnvironmentModelShape a sh:NodeShape ; | |||
sh:property [ sh:maxCount 1 ; | |||
sh:minCount 1 ; | |||
sh:node general:GeneralShape ; | |||
sh:name "generalObject" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the "Object" suffix in each and every sh:name
field?
There are other examles like in scenario_shacl.ttl
:
[ skos:example "http://mywebsite.de/map.xodr" ;
sh:description "Link to traffic space"@en ;
sh:maxCount 1 ;
sh:message "Validation of trafficSpace failed!"@en ;
sh:minCount 0 ;
sh:name "trafficSpace"@en ;
sh:node general:LinkShape ;
sh:order 2 ;
sh:path scenario:trafficSpace ] ;
I would prefer to have it comparable to the other name
fields.
BTW: sh:name
can be even a speaking token, e. g. gx_shacl.ttl:
[ sh:description "a resolvable link to the participant self-description legally enabling the data usage." ;
sh:maxCount 1 ;
sh:minCount 1 ;
sh:name "produced by" ;
sh:node gx:LegalParticipant ;
sh:nodeKind sh:IRI ;
sh:order 2 ;
sh:path gx:producedBy ],
Description
add name and description to groups for all shacls
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any
relevant details for your test configuration
Checklist