dead_letter_exchanges in RabbitMQ #372
Conversation
| rabbitmq: RabbitMQService | ||
|
|
||
| def __init__( | ||
| self, options: RabbitMQTopic.Options, services: Services, **kwargs: object |
There was a problem hiding this comment.
Since we inherit from RabbitMQTopic.Options we have the deat_letter_queue parameters which is not supported here... Maybe we should add a warning if the param is set.
infherny
force-pushed
the
olivier/dead_letter_exchanges
branch
from
2f67bfa
to
f50fc4f
Compare
|
@isra17 wdyt |
infherny
force-pushed
the
olivier/dead_letter_exchanges
branch
from
f50fc4f
to
a429131
Compare
| @@ -308,3 +315,39 @@ def _deserialize( | |||
| return deserialized | |||
|
|
|||
| return fromdict(json.loads(message.body.decode()), TopicMessage) | |||
|
|
|||
|
|
|||
| class RabbitMQDeadLetterTopic(RabbitMQTopic): | |||
There was a problem hiding this comment.
nit: DeadLetterRabbitMQTopic
| @@ -72,6 +72,7 @@ class Options: | |||
| log_above_size: t.Optional[int] = None | |||
| max_publish_concurrency: int = 8 | |||
| max_retry: int | None = None | |||
| dead_letter_queue: str | None = None | |||
There was a problem hiding this comment.
I would suggest two changes that would cover everything we need:
- Add a
queue_arguments: dict, that we can just pass as-is todeclare_queue. This way we won't have to open a new PR each time we want something new. - Add an
exchange_name: Optional[str]that we can use to declare and bind an exchange is notNone?
This way we don't need to create a new class
There was a problem hiding this comment.
Might as well make it exchange: Optional[ExchangeOptions] so we support the few exchange parameters and can do fanout with this PR as well.
@dataclass
class ExchangeOptions:
name: str
type: ExchangeType
...
There was a problem hiding this comment.
But we still need to knew its a dead letter queue for the arguments no?
There was a problem hiding this comment.
(All the options: https://aio-pika.readthedocs.io/en/latest/apidoc.html#aio_pika.Channel.declare_exchange)
Seems like durable we need to set True
infherny
force-pushed
the
olivier/dead_letter_exchanges
branch
from
a429131
to
02c773a
Compare
| arguments: dict[str, t.Any] = {} | ||
| arguments: dict[str, t.Any] = self.options.arguments | ||
|
|
||
| # Backward compatible arguments | ||
| if self.options.max_length: |
| @@ -10,7 +10,6 @@ | |||
| from .null import NullTopic | |||
| from .periodic import PeriodicTopic | |||
| from .rabbitmq import RabbitMQTopic | |||
| from .static import StaticTopic | |||
infherny
force-pushed
the
olivier/dead_letter_exchanges
branch
from
02c773a
to
24a9408
Compare
No description provided.